sqlite: restore changes from #55373 #56908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR nodejs#55373 introduced a performance improvement for the all() method of prepared statements. Those changes appear to have been accidentally overwritten in nodejs#54181. This change restores the overwritten code. Refs: nodejs#55373 Refs: nodejs#54181
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56908 +/- ##
==========================================
- Coverage 89.19% 89.19% -0.01%
==========================================
Files 665 665
Lines 192488 192503 +15
Branches 37047 37043 -4
==========================================
+ Hits 171698 171699 +1
- Misses 13622 13623 +1
- Partials 7168 7181 +13
|
targos
approved these changes
Feb 4, 2025
github-actions
bot
removed
the
request-ci
cjihrig
added
author ready
aduh95
approved these changes
Feb 5, 2025
aduh95
added
needs-ci
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1671921 |
Yeaseen
pushed a commit
to Yeaseen/node
that referenced
this pull request
Feb 6, 2025
PR nodejs#55373 introduced a performance improvement for the all() method of prepared statements. Those changes appear to have been accidentally overwritten in nodejs#54181. This change restores the overwritten code. Refs: nodejs#55373 Refs: nodejs#54181 PR-URL: nodejs#56908 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 7, 2025
PR #55373 introduced a performance improvement for the all() method of prepared statements. Those changes appear to have been accidentally overwritten in #54181. This change restores the overwritten code. Refs: #55373 Refs: #54181 PR-URL: #56908 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #55373 introduced a performance improvement for the
all()method of prepared statements. Those changes appear to have been accidentally overwritten in #54181. This change restores the overwritten code.Refs: #55373
Refs: #54181